Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Remove deprecated ControllerManagerConfig #2087

Merged
merged 1 commit into from
Nov 28, 2024
Merged

🌱 Remove deprecated ControllerManagerConfig #2087

merged 1 commit into from
Nov 28, 2024
+0 −59

Conversation

hex2dec
Copy link
Contributor

@hex2dec hex2dec commented Nov 28, 2024

What this PR does / why we need it:

The ComponentConfig has been deprecated in the controller-runtime since v0.15.0. Remove this component config because it is no longer used by the baremetal operator.

@hex2dec
🌱 Remove deprecated ControllerManagerConfig
87c8763 
The ComponentConfig has been deprecated in the controller-runtime
since v0.15.0.

Signed-off-by: Zhiwei Huang <[email protected]>
@metal3-io-bot
Copy link
Contributor

Hi @hex2dec. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2024
@tuminoid
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 28, 2024
@tuminoid
Copy link
Member

/cc @kashifest @lentzi90 @elfosardo

lentzi90
lentzi90 reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2024
@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2024
@metal3-io-bot metal3-io-bot merged commit b04f9d8 into metal3-io:main Nov 28, 2024
15 checks passed
@hex2dec hex2dec deleted the controller-manager-config branch November 29, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@Rozzii Rozzii Awaiting requested review from Rozzii

@tuminoid tuminoid Awaiting requested review from tuminoid

@elfosardo elfosardo Awaiting requested review from elfosardo

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hex2dec @metal3-io-bot @tuminoid @elfosardo @lentzi90